Remove unnecessary usages of `format!` macro.
authorCorey Farwell <coreyf@rwell.org>
Sat, 6 Aug 2016 02:15:27 +0000 (22:15 -0400)
committerCorey Farwell <coreyf@rwell.org>
Sat, 6 Aug 2016 02:15:27 +0000 (22:15 -0400)
src/cargo/util/cfg.rs
src/cargo/util/toml.rs

index 95b20e508f2fcf7357bf81a8955e5ec6803b9693..fbdfb919eeddee6e7e971e1678b52c1930cb92f2 100644 (file)
@@ -215,7 +215,7 @@ impl<'a> Iterator for Tokenizer<'a> {
                             return Some(Ok(Token::String(&self.orig[start+1..end])))
                         }
                     }
-                    return Some(Err(human(format!("unterminated string in cfg"))))
+                    return Some(Err(human("unterminated string in cfg".to_string())))
                 }
                 Some((start, ch)) if is_ident_start(ch) => {
                     while let Some(&(end, ch)) = self.s.peek() {
index 9a7e2135a17d370fb7c70618cd822ec905e99b84..6fe9e285f0e311bb93dc5485044369fe0dc43550 100644 (file)
@@ -653,8 +653,8 @@ impl TomlManifest {
                                          replace,
                                          workspace_config);
         if project.license_file.is_some() && project.license.is_some() {
-            manifest.add_warning(format!("only one of `license` or \
-                                          `license-file` is necessary"));
+            manifest.add_warning("only one of `license` or \
+                                 `license-file` is necessary".to_string());
         }
         for warning in warnings {
             manifest.add_warning(warning.clone());
@@ -924,7 +924,7 @@ impl TomlTarget {
         match self.name {
             Some(ref name) => {
                 if name.trim().is_empty() {
-                    Err(human(format!("library target names cannot be empty.")))
+                    Err(human("library target names cannot be empty.".to_string()))
                 } else if name.contains("-") {
                     Err(human(format!("library target names cannot contain hyphens: {}",
                                       name)))
@@ -940,12 +940,12 @@ impl TomlTarget {
         match self.name {
             Some(ref name) => {
                 if name.trim().is_empty() {
-                    Err(human(format!("binary target names cannot be empty.")))
+                    Err(human("binary target names cannot be empty.".to_string()))
                 } else {
                     Ok(())
                 }
             },
-            None => Err(human(format!("binary target bin.name is required")))
+            None => Err(human("binary target bin.name is required".to_string()))
         }
     }
 
@@ -953,12 +953,12 @@ impl TomlTarget {
         match self.name {
             Some(ref name) => {
                 if name.trim().is_empty() {
-                    Err(human(format!("example target names cannot be empty")))
+                    Err(human("example target names cannot be empty".to_string()))
                 } else {
                     Ok(())
                 }
             },
-            None => Err(human(format!("example target example.name is required")))
+            None => Err(human("example target example.name is required".to_string()))
         }
     }
 
@@ -966,12 +966,12 @@ impl TomlTarget {
         match self.name {
             Some(ref name) => {
                 if name.trim().is_empty() {
-                    Err(human(format!("test target names cannot be empty")))
+                    Err(human("test target names cannot be empty".to_string()))
                 } else {
                     Ok(())
                 }
             },
-            None => Err(human(format!("test target test.name is required")))
+            None => Err(human("test target test.name is required".to_string()))
         }
     }
 
@@ -979,12 +979,12 @@ impl TomlTarget {
         match self.name {
             Some(ref name) => {
                 if name.trim().is_empty() {
-                    Err(human(format!("bench target names cannot be empty")))
+                    Err(human("bench target names cannot be empty".to_string()))
                 } else {
                     Ok(())
                 }
             },
-            None => Err(human(format!("bench target bench.name is required")))
+            None => Err(human("bench target bench.name is required".to_string()))
         }
     }
 }